chore: Convert SentryFramesTrackingIntegration to Swift#7044
Merged
Conversation
Contributor
Author
|
Lint fails, and that's expected for now, enable |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7044 +/- ##
=============================================
+ Coverage 85.015% 85.046% +0.031%
=============================================
Files 468 468
Lines 28249 28241 -8
Branches 12532 12526 -6
=============================================
+ Hits 24016 24018 +2
+ Misses 4192 4182 -10
Partials 41 41
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…coa-999-refactor-sentryframestrackingintegrationm-in-swift
itaybre
requested review from
noahsmartin,
philipphofmann and
philprime
as code owners
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| bb418da | 1227.60 ms | 1265.90 ms | 38.30 ms |
| 7e93d85 | 1205.28 ms | 1243.71 ms | 38.44 ms |
| dbfeb41 | 1215.17 ms | 1237.41 ms | 22.23 ms |
| f84c826 | 1216.38 ms | 1241.98 ms | 25.60 ms |
| b5c1b24 | 1217.94 ms | 1248.76 ms | 30.82 ms |
| 9f7ef2b | 1213.53 ms | 1250.23 ms | 36.70 ms |
| adeec82 | 1220.43 ms | 1254.94 ms | 34.51 ms |
| d29a425 | 1209.96 ms | 1239.00 ms | 29.04 ms |
| 2f4ddaa | 1227.26 ms | 1260.04 ms | 32.78 ms |
| 58a9225 | 1211.40 ms | 1238.88 ms | 27.48 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| bb418da | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 7e93d85 | 24.14 KiB | 1.06 MiB | 1.04 MiB |
| dbfeb41 | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| f84c826 | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| b5c1b24 | 24.14 KiB | 1.06 MiB | 1.04 MiB |
| 9f7ef2b | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| adeec82 | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| d29a425 | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 2f4ddaa | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 58a9225 | 24.14 KiB | 1.06 MiB | 1.04 MiB |
Previous results on branch: itay/cocoa-999-refactor-sentryframestrackingintegrationm-in-swift
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c230748 | 1212.21 ms | 1242.60 ms | 30.39 ms |
| 638b07b | 1216.77 ms | 1245.51 ms | 28.74 ms |
| 7c7d5e2 | 1224.90 ms | 1255.13 ms | 30.23 ms |
| 9b8916c | 1223.80 ms | 1245.29 ms | 21.49 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c230748 | 24.14 KiB | 1.03 MiB | 1.01 MiB |
| 638b07b | 24.14 KiB | 1.03 MiB | 1.01 MiB |
| 7c7d5e2 | 24.14 KiB | 1.03 MiB | 1.00 MiB |
| 9b8916c | 24.14 KiB | 1.03 MiB | 1.00 MiB |
philprime
reviewed
Dec 18, 2025
Sources/Swift/Integrations/Performance/FramesTracking/SentryFramesTrackingIntegration.swift
Show resolved
Hide resolved
…ntryBaseIntegration.m
noahsmartin
reviewed
Dec 23, 2025
noahsmartin
reviewed
Dec 23, 2025
noahsmartin
approved these changes
Dec 23, 2025
…coa-999-refactor-sentryframestrackingintegrationm-in-swift
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…coa-999-refactor-sentryframestrackingintegrationm-in-swift
…coa-999-refactor-sentryframestrackingintegrationm-in-swift
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
itaybre
deleted the
itay/cocoa-999-refactor-sentryframestrackingintegrationm-in-swift
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts
SentryFramesTrackingIntegrationto Swift as part of the Swift project#skip-changelog
Closes #7066